Change the output of sample_at_coords() to have units
#6882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayshih
added
the
No Backport
wtbarnes
approved these changes
Apr 3, 2023
nabobalis
approved these changes
Apr 4, 2023
|
Needs a rebase but looks good to me. Happy to break due to the reason Will has given. |
|
Oh, whoops, I figured this would get merged before #6840, so I didn't mention in #6840 that it had been rebased on top of this PR. So, the changes here, including the changelog entry, are already in with the merging of #6840. I don't think it makes sense to rebase this PR, which would wipe out the single commit here and make it more difficult for future readers to understand. I'll just close this PR, and we'll live with the weirdness of having our changelog point to a PR that wasn't directly merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason,
sunpy.map.maputils.sample_at_coords()doesn't return aQuantitywhen sampling pixel values. This PR fixes that oversight, although this is an API change that could break code in the wild without any practical way to have a deprecation period.