Add support for Map to load from a generator

[Jett-Code]

PR Description

Fixes #7022

[nabobalis]

Looks like this change has failed on the CI, this will need debugging.

This will need a unit test as well to check that pathlib.glob works.

[Jett-Code]

Looks like this change has failed on the CI, this will need debugging.

This will need a unit test as well to check that pathlib.glob works.

Could you please guide me on how to write unit tests for this?

[nabobalis]

Looks like this change has failed on the CI, this will need debugging.
This will need a unit test as well to check that pathlib.glob works.

Could you please guide me on how to write unit tests for this?

You will want to add a unit test to https://github.com/sunpy/sunpy/blob/main/sunpy/map/tests/test_map_factory.py

that basically runs some version of this code:

import pathlib
import sunpy.map
sunpy.map.Map(pathlib.Path.home().glob('*.fits'))

with the path correctly changed to use some test data.
To ensure we support this feature.

You will want to add extra unit tests to https://github.com/sunpy/sunpy/blob/main/sunpy/util/tests/test_util.py to ensure that we skip over strings correctly.

Hopefully that helps.

[Jett-Code]

You will want to add extra unit tests to https://github.com/sunpy/sunpy/blob/main/sunpy/util/tests/test_util.py to ensure that we skip over strings correctly.

There are already two unit test cases for string, list, and tuples. Do you want me to add extra on top of that?
lst = ['a', 'b', [], (['c', 'd']), tuple(), ['e']]

[nabobalis]

There are already two unit test cases for string, list, and tuples. Do you want me to add extra on top of that? lst = ['a', 'b', [], (['c', 'd']), tuple(), ['e']]

If the tests for those are already there, then its ok. But what if you just pass in a string?

The other unit tests are failing with these changes, we need to debug this.

[nabobalis]

The last set of pushes broke the pull request, can you revert it or fix it please?

[Jett-Code]

The last set of pushes broke the pull request, can you revert it or fix it please?

Is it possible to delete the last commit?

[nabobalis]

The last set of pushes broke the pull request, can you revert it or fix it please?

Is it possible to delete the last commit?

Do we not need the changes in that commit?

[nabobalis]

The entire commit history is a bit strange right now. Seems to be repeated?

[nabobalis]

I pushed from an old branch I had locally. Not sure if it was up to date tho.

[Jett-Code]

I pushed from an old branch I had locally. Not sure if it was up to date tho.

Thanks, let me check

[Jett-Code]

I guess everything is working fine now

[Jett-Code]

Is there anything else to work on regarding this pr?

[nabobalis]

Is there anything else to work on regarding this pr?

No, it needs reviews from the other mainainters before a merge.

[nabobalis]

Thanks for the PR @Jett-Code, sorry it took so long on our side.