Fix bug in get_horizons_coord time dictionary arg #7106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samaloney
force-pushed
the
bugfix-horizons-coord-dict
branch
3 times, most recently
from
77d89b2
to
0b2355f
Compare
samaloney
force-pushed
the
bugfix-horizons-coord-dict
branch
from
0b2355f
to
80555bf
Compare
ayshih
requested changes
Jul 18, 2023
There was a problem hiding this comment.
Can you also add a line to convert the returned obstime back to UTC when a dictionary is input? That is, add a line after this one:
sunpy/sunpy/coordinates/ephemeris.py
Line 329 in 64419c2
Co-authored-by: Albert Y. Shih <ayshih@gmail.com>
nabobalis
added
backport 5.0
ayshih
requested changes
Aug 18, 2023
Co-authored-by: Albert Y. Shih <ayshih@gmail.com>
dstansby
approved these changes
Aug 31, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/sunpy
that referenced
this pull request
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fix small bug in get_horizons_coord when time is specified using the dictionary format. Update code to pass full time spec (including milliseconds) to astroquery.
Closes #7105