Typo correction to the frameless example #7134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
added
No Changelog Entry Needed
Minor Change
Cadair
reviewed
Aug 9, 2023
examples/map/plot_frameless_image.py
Outdated
Comment on lines
41
to
43
| # At this point you could save the figure with ``plt.savefig()`` or show it: | ||
| # At this point you could save the figure with :meth:`~matplotlib.pyplot.savefig` | ||
| # or show it: |
There was a problem hiding this comment.
Why? this should link to savefig no?
There was a problem hiding this comment.
it should have done before and wont now? I don't understand why you changed this?
There was a problem hiding this comment.
I feel like @Cadair is misreading... It certainly wasn't linking before, and so this fix is in the right direction, but :meth: needs to be :func:
nabobalis
changed the title
alasdairwilson
approved these changes
Aug 17, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/sunpy
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically a typo