Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

See if increasing min deps helps figure test pass #7144

Merged
merged 1 commit into from Aug 17, 2023
Merged

See if increasing min deps helps figure test pass #7144

merged 1 commit into from Aug 17, 2023

Conversation

nabobalis
Copy link
Contributor

@nabobalis nabobalis commented Aug 14, 2023 •
edited

Figure tests needed increase in some deps to avoid new errors from other updated packages.

@nabobalis nabobalis added No Changelog Entry Needed Infrastructure Issues or PRs that affect the CI or packaging of SunPy Minor Change PR only needs one approval to merge backport 5.0 on-merge: backport to 5.0 labels Aug 14, 2023
@nabobalis nabobalis force-pushed the figures branch 3 times, most recently from f27e779 to 23945ab Compare August 14, 2023 17:47
@nabobalis nabobalis marked this pull request as ready for review August 14, 2023 17:53
alasdairwilson
alasdairwilson approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@alasdairwilson alasdairwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful.

@nabobalis
Copy link
Contributor Author

Very useful.

I provide only the most useful PRs.

@nabobalis nabobalis merged commit d9f539a into sunpy:main Aug 17, 2023
20 of 23 checks passed
@nabobalis nabobalis deleted the figures branch August 17, 2023 18:14
meeseeksmachine pushed a commit to meeseeksmachine/sunpy that referenced this pull request Aug 17, 2023
@nabobalis @meeseeksmachine
Backport PR sunpy#7144: See if increasing min deps helps figure test …
73e5d5e 
…pass
@meeseeksmachine meeseeksmachine mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alasdairwilson alasdairwilson alasdairwilson approved these changes

Assignees
No one assigned
Labels
backport 5.0 on-merge: backport to 5.0 Infrastructure Issues or PRs that affect the CI or packaging of SunPy Minor Change PR only needs one approval to merge No Changelog Entry Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nabobalis @alasdairwilson