New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removes incorrect block indices from asdf test data #7145
Conversation
It appears that pre-commit is modifying the data files. Perhaps exclude: "\\.asdf$" EDIT: edited regex to better match just files with |
Yeah, we need to add that to the precommit |
Thanks! Would you like me to sneak that in here? |
Yes please! |
222646f
to
c65b3b0
Compare
I wanted to run the devdeps test that requires a label plus reopening a PR. Sorry for the trouble. |
Thank you @braingram |
Thanks! @nabobalis |
PR Description
Asdf is making some major updates to internal block reading and writing code (see this PR for the extensive changes).
One of the changes includes issuing a new warning when a file is opened which contains an incorrect block index. The block index is a small, optional YAML document at the end of an ASDF file that contains the offsets of each ASDF binary block within the ASDF file (see the asdf-standard docs for more details). Hand editing ASDF files can often lead to incorrect offsets in the block index. When asdf detects a block index that is incorrect (or if no block index is found) it ignores the block index and falls back to reading blocks sequentially starting with the first.
With sunpy main tested against the above asdf PR several tests are failing (see here for the full log):
This is due to 2 test files in the sunpy repository that contain block index offsets that are incorrect (see the changed files in this PR).
This PR deletes the invalid block index from each of these files.