Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old limb drawing function #7202

Merged
merged 3 commits into from Oct 9, 2023
Merged

Remove old limb drawing function #7202

merged 3 commits into from Oct 9, 2023

Conversation

dstansby
Copy link
Member

Deprecated in 4.1, so time to 🗑️

hayesla
hayesla approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@hayesla hayesla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just an update the changelog name and then good to go

@dstansby dstansby marked this pull request as ready for review September 18, 2023 11:05
@dstansby dstansby requested a review from a team as a code owner September 18, 2023 11:05
@dstansby dstansby added Needs Review Needs reviews before merge No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) labels Sep 18, 2023
@wtbarnes wtbarnes added this to the 5.1.0 milestone Oct 4, 2023
Cadair
Cadair requested changes Oct 9, 2023
View reviewed changes
Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc build fail is real

Cadair
Cadair approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: thanks @wtbarnes

@Cadair Cadair merged commit 6feafb9 into sunpy:main Oct 9, 2023
25 of 26 checks passed
@dstansby dstansby deleted the remove-old-limb-draw branch October 9, 2023 18:45
@nabobalis nabobalis mentioned this pull request Jan 31, 2024
Merged
@nabobalis nabobalis removed the Needs Review Needs reviews before merge label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cadair Cadair Cadair approved these changes

@hayesla hayesla hayesla approved these changes

Assignees
No one assigned
Labels
No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers)
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dstansby @Cadair @hayesla @nabobalis @wtbarnes