Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GOES tests for new files #7226

Merged
merged 4 commits into from Oct 10, 2023
Merged

Update GOES tests for new files #7226

merged 4 commits into from Oct 10, 2023

Conversation

nabobalis
Copy link
Contributor

Should fix the online tests for now.

@nabobalis nabobalis added Tests Affects tests in some measure net Affects the net submodule No Changelog Entry Needed Minor Change PR only needs one approval to merge backport 5.0 on-merge: backport to 5.0 labels Oct 9, 2023
@nabobalis nabobalis requested a review from a team as a code owner October 9, 2023 19:30
@dstansby dstansby added the Merge When CI Passes Hit that merge button when it's all green! label Oct 9, 2023
hayesla
hayesla approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@hayesla hayesla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOES gives again 🙏

@nabobalis
Copy link
Contributor Author

The previous Online CI failed due to a warning that it was using a different endpoint for the VSO. After speaking with @Cadair, we do not want this stop the CI as this isn't a warning that 1) is a problem unless its failed to fallback 2) means we have to run the suite again.

Due to our policy of not using warnings.warn directly, we have to create a new function even if this is getting very silly. In future, we need to refactor this.

@nabobalis @Cadair
Fixed docstring
3ef219c 
Co-authored-by: Stuart Mumford <stuart@cadair.com>
@nabobalis
Copy link
Contributor Author

Online test suite failed with:

FAILED ../../.tox/py39-online/lib/python3.9/site-packages/sunpy/net/tests/test_fido.py::test_path
FAILED ../../.tox/py39-online/lib/python3.9/site-packages/sunpy/net/vso/tests/test_vso.py::test_path
FAILED ../../docs/tutorial/acquiring_data/index.rst::index.rst

These are socket timeouts to the VSO all on the same file it looks like.

@nabobalis nabobalis merged commit 10f6f05 into sunpy:main Oct 10, 2023
20 of 25 checks passed
@nabobalis nabobalis deleted the ci branch October 10, 2023 10:31
meeseeksmachine pushed a commit to meeseeksmachine/sunpy that referenced this pull request Oct 10, 2023
@nabobalis @meeseeksmachine
Backport PR sunpy#7226: Update GOES tests for new files
46385cd
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cadair Cadair Cadair left review comments

@hayesla hayesla hayesla approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
backport 5.0 on-merge: backport to 5.0 Merge When CI Passes Hit that merge button when it's all green! Minor Change PR only needs one approval to merge net Affects the net submodule No Changelog Entry Needed Tests Affects tests in some measure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nabobalis @Cadair @hayesla @dstansby