Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed HelioviewerClient #7338

Merged
merged 5 commits into from Jan 4, 2024
Merged

Removed HelioviewerClient #7338

merged 5 commits into from Jan 4, 2024

Conversation

nabobalis
Copy link
Contributor

Deprecated from 4.1

@nabobalis nabobalis added No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) net Affects the net submodule Whats New? Needs a section added to the current Whats New? page. labels Dec 7, 2023
@nabobalis nabobalis marked this pull request as ready for review December 28, 2023 00:32
@nabobalis nabobalis requested a review from a team as a code owner December 28, 2023 00:32
@nabobalis nabobalis added the Minor Change PR only needs one approval to merge label Dec 28, 2023
wtbarnes
wtbarnes approved these changes Jan 4, 2024
View reviewed changes
docs/whatsnew/6.0.rst Outdated Show resolved Hide resolved
changelog/7338.removal.rst Outdated Show resolved Hide resolved
@nabobalis @wtbarnes
Apply suggestions from code review
af59818 
Co-authored-by: Will Barnes <will.t.barnes@gmail.com>
@nabobalis nabobalis modified the milestone: 5.1.1 Jan 4, 2024
@nabobalis nabobalis merged commit d4ae1f4 into sunpy:main Jan 4, 2024
25 of 26 checks passed
@nabobalis nabobalis deleted the dep_helio branch January 4, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtbarnes wtbarnes wtbarnes approved these changes

Assignees
No one assigned
Labels
Minor Change PR only needs one approval to merge net Affects the net submodule No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) Whats New? Needs a section added to the current Whats New? page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nabobalis @wtbarnes