Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed positional argument support for reproject_to #7339

Merged
merged 4 commits into from Jan 4, 2024
Merged

Removed positional argument support for reproject_to #7339

merged 4 commits into from Jan 4, 2024

Conversation

nabobalis
Copy link
Contributor

Deprecated since 4.1

@nabobalis nabobalis added No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) Whats New? Needs a section added to the current Whats New? page. labels Dec 7, 2023
@nabobalis nabobalis added the map Affects the map submodule label Dec 28, 2023
@nabobalis nabobalis marked this pull request as ready for review December 28, 2023 00:51
@nabobalis nabobalis requested a review from a team as a code owner December 28, 2023 00:51
@nabobalis nabobalis added the Minor Change PR only needs one approval to merge label Dec 28, 2023
dstansby
dstansby approved these changes Jan 2, 2024
View reviewed changes
changelog/7339.breaking.rst Outdated Show resolved Hide resolved
@dstansby dstansby removed the Minor Change PR only needs one approval to merge label Jan 2, 2024
@nabobalis @dstansby
[ ci skip ] Update changelog/7339.breaking.rst
c5e1b02 
Co-authored-by: David Stansby <dstansby@gmail.com>
@wtbarnes wtbarnes merged commit 1c534f7 into sunpy:main Jan 4, 2024
22 of 24 checks passed
@nabobalis nabobalis deleted the dep_reproject branch January 5, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby approved these changes

@wtbarnes wtbarnes wtbarnes approved these changes

Assignees
No one assigned
Labels
map Affects the map submodule No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) Whats New? Needs a section added to the current Whats New? page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nabobalis @dstansby @wtbarnes