Double check a non-empty but not None value was provided to jsoc notify #7342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
added
net
nabobalis
force-pushed
the
jsoc_email
branch
from
5a2b203
to
d74bba2
Compare
nabobalis
commented
Dec 28, 2023
dstansby
requested changes
Jan 2, 2024
dstansby
approved these changes
Jan 2, 2024
wtbarnes
approved these changes
Jan 4, 2024
nabobalis
changed the title
Co-authored-by: David Stansby <dstansby@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This catches me out when running examples sometimes, as if you do not index the os.environ dict but use .get, you get a default value. I guess the answer is to fix the example but either way, we should catch this.