Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove filter on warnings for release docs #7372

Merged
merged 1 commit into from Jan 10, 2024
Merged

Conversation

nabobalis
Copy link
Contributor

@nabobalis nabobalis commented Jan 8, 2024

Fixes #7301

@nabobalis nabobalis added Documentation Affects the documentation No Changelog Entry Needed backport 5.0 on-merge: backport to 5.0 backport 5.1 on-merge: backport to 5.1 labels Jan 8, 2024
@nabobalis nabobalis marked this pull request as ready for review January 8, 2024 21:45
docs/conf.py Outdated Show resolved Hide resolved
@wtbarnes wtbarnes merged commit 6b159bc into sunpy:main Jan 10, 2024
23 of 25 checks passed
Copy link

lumberbot-app bot commented Jan 10, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 5.0
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 6b159bccef032e12a1a2cb7549dd57fbff7a20a5
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #7372: remove filter on warnings for release docs'
  1. Push to a named branch:
git push YOURFORK 5.0:auto-backport-of-pr-7372-on-5.0
  1. Create a PR against branch 5.0, I would have named this PR:

"Backport PR #7372 on branch 5.0 (remove filter on warnings for release docs)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@lumberbot-app lumberbot-app bot added the Still Needs Manual Backport This PR needs manually backporting label Jan 10, 2024
meeseeksmachine pushed a commit to meeseeksmachine/sunpy that referenced this pull request Jan 10, 2024
@nabobalis nabobalis deleted the warning branch January 10, 2024 19:14
nabobalis added a commit that referenced this pull request Jan 10, 2024
…2-on-5.1

Backport PR #7372 on branch 5.1 (remove filter on warnings for release docs)
@nabobalis nabobalis removed the Still Needs Manual Backport This PR needs manually backporting label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 5.0 on-merge: backport to 5.0 backport 5.1 on-merge: backport to 5.1 Documentation Affects the documentation No Changelog Entry Needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User confusion because warnings are hidden in gallery examples for stable docs
3 participants