Add pyerfa as core dep and fix imports (fixes devdeps)

[nabobalis]

Import has now changed.

[ayshih]

You have to add pyerfa as a test dependency (even though it should always be there because of astropy).

Given that, you might as well also make the long overdue change of specifying pyerfa as a core dependency and fix the two funny-looking imports in #4343.

[ayshih]

("long overdue" because we could have "fixed" those imports once Astropy 4.2 became the minimum dependency)

[nabobalis]

Done.

[dstansby]

The new dependency should get a changelog entry. Also I'm not sure about backporting a new dependency... can we just ignore the warning on 5.x?

[nabobalis]

The new dependency should get a changelog entry. Also I'm not sure about backporting a new dependency... can we just ignore the warning on 5.x?

Hmm, I would say that since pyefra has been a core dependency of astropy for years now, the fact we are adding to ours I don't think changes anything.

I can add the ignore warning to those releases.

I will leave this choice up to you and Albert.

[ayshih]

While pyerfa would become a new direct dependency, it has been an indirect dependency since our minimum astropy dependency became 4.2 (i.e., sunpy 3.1, over two years ago). That is, making an indirect dependency a direct dependency has zero effect on anyone with a valid installation of sunpy 3.1+, since their environment is "guaranteed" to have pyerfa present.

My inclination is to go ahead with the backport, because it cleans up the code, but I do think there should be a changelog (trivial), primarily to alert anyone who might have a bizarrely inconsistent environment.

[nabobalis]

Rebaesd and added changelog.

[ayshih]

Can you do me a favor and add it to sunpy-dev-env.yml as well?

[nabobalis]

Ah I forgot! Sorry.

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

git checkout 5.0
git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 3f9d063adae5bd36be6df2a0712b47b829a26119

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #7397: Add pyerfa as core dep and fix imports (fixes devdeps)'

4. Push to a named branch:

git push YOURFORK 5.0:auto-backport-of-pr-7397-on-5.0

5. Create a PR against branch 5.0, I would have named this PR:

"Backport PR #7397 on branch 5.0 (Add pyerfa as core dep and fix imports (fixes devdeps))"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

git checkout 5.1
git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 3f9d063adae5bd36be6df2a0712b47b829a26119

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #7397: Add pyerfa as core dep and fix imports (fixes devdeps)'

4. Push to a named branch:

git push YOURFORK 5.1:auto-backport-of-pr-7397-on-5.1

5. Create a PR against branch 5.1, I would have named this PR:

"Backport PR #7397 on branch 5.1 (Add pyerfa as core dep and fix imports (fixes devdeps))"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.