Implemented the vector transformation from one frame to another #7452
+101
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
reviewed
Feb 16, 2024
| assert isinstance(result, u.Quantity) | ||
|
|
||
| # Check that the result has the correct shape | ||
| assert result.shape == components.shape |
There was a problem hiding this comment.
Should we not check the output is correct?
There was a problem hiding this comment.
Yes, it indeed must be checked. I was also thinking of implementing a test that examines all potential frame conversions. Would that be advantageous?
Can you let me know if this is something we should consider or if the existing single test for conversion suffices? |
|
I have requested for this to be reviewed and we will wait for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
As requested in the #7389 this PR adds a vector transformation function in the spice module that will convert the vector from one frame to another.
TODO