ADAPT Client

[GillySpace27]

PR Description

Adds functionality to download ADAPT maps using FIDO.
This addresses the following issue: #7152

I believe that the core of this code works but I cant get a dev environment running to test things. I believe I'll have to do more work putting the right parts in the right places for sunpy, but I wanted to get this started by uploading what I have.

[GillySpace27]

Ok, I think that the client works now, though there may be some code linting that could be helpful.

[nabobalis]

Thanks for the PR @GillySpace27!

I hope it was ok for me to look over this while it was in draft.

[GillySpace27]

I think I did everything except for the test parts, which I'm not experienced with. Please feel free to give this another once-over.

[nabobalis]

Hi @GillySpace27, sorry for not getting back to you sooner, I will go over this soon but I have two suggestions:

1. Can you add back "sunpy/net/dataretriever/sources/init.py", I think that has to be there.

2. For the tests, you can avoid having to write the tests from scratch by just copying the file from say one of the goes test files, update the client to use adapt and then tweak the calls to the client with the correct attrs. That should reduce the burden on you and would cover most of the tests we would need for a new client.

[GillySpace27]

Thanks for the additional comments! I did everything except the tests, which I will definitely get around to ASAP. Let me know if you see anything else!

[GillySpace27]

I just adjusted the main client in response to your comments, but I still haven't touched the tests, which seem daunting. Is there anything else I should do in addition to the tests?

[nabobalis]

I just adjusted the main client in response to your comments, but I still haven't touched the tests, which seem daunting. Is there anything else I should do in addition to the tests?

I can have a look, but for the tests, I could just copy the tests from another client and just modify the names. That should cover most of the tests we would need.

[GillySpace27]

I just adjusted the main client in response to your comments, but I still haven't touched the tests, which seem daunting. Is there anything else I should do in addition to the tests?

I can have a look, but for the tests, I could just copy the tests from another client and just modify the names. That should cover most of the tests we would need.

If you are able to make those changes, that would be rad! looking at the changes you make would probably be useful for me to see. I just copied over the file in my most recent commit.

[nabobalis]

Hi @GillySpace27, I rebased and updated the tests, they should cover what we need.

[nabobalis]

Hi @GillySpace27, I would suggest that instead of trying to merge in the changes locally, that it would be better to run:

git remote update -p
git reset --hard origin/main

This will update your local repo and reset all local changes to point to the current version that is on GitHub.

If you have any questions about git, please just let know!

[nabobalis]

I forgot how annoying our net subset of unit tests are.

I am still trying to work out what is going on and fix it.
More developer documentation has to be written to account for all these.

[GillySpace27]

Thanks for your help getting this sorted out! Let me know if you need anything from me. :)

[nabobalis]

Thanks for your help getting this sorted out! Let me know if you need anything from me. :)

Sorry I kind of just took over. There were some parts that I had to recall how it worked for me to patch. I need to increase the developer guide with more details so its more helpful.

If you are ok with the changes, and want to check it still works how you expect it to, that would be great. Then I can merge it.

[GillySpace27]

So what happens now? I just ran the git commands you suggested and then tested the code by running the example in the docstring, and it seems like it's behaving as expected!

[nabobalis]

Right now, I need to wait for another review before we should merge.

I am hoping that will come as we want to get 6.0 out.

[GillySpace27]

Thanks again for your help! I'll mark this off as a backburnered project until I hear back from you all. I hope it makes it in to the release!

[nabobalis]

Online fails are due to HEK and nothing to do with this PR.

[nabobalis]

Thanks for the PR @GillySpace27, sorry it took so long.