Deprecated response_format in vso search #7468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
force-pushed
the
dep_response_format
branch
2 times, most recently
from
bab74cc
to
999f746
Compare
nabobalis
commented
Mar 2, 2024
|
|
||
| @deprecated_renamed_argument("vso_response_format", None,"6.0", warning_type=SunpyDeprecationWarning) | ||
| @deprecated_renamed_argument("progress", None,"6.0", warning_type=SunpyDeprecationWarning) |
There was a problem hiding this comment.
The other choice is to pass progress down so it works?
There was a problem hiding this comment.
Why would we deprecate it in full_query but not here? Maybe I'm missing some context
There was a problem hiding this comment.
I mean more, I could work out how where progress should be passed and then not deprecate it across everything.
But since we never used it, I feel like removing it anyway.
wtbarnes
reviewed
Mar 7, 2024
wtbarnes
approved these changes
Mar 7, 2024
wtbarnes
added
Needs Review
nabobalis
commented
Mar 20, 2024
Co-authored-by: David Stansby <dstansby@gmail.com>
nabobalis
force-pushed
the
dep_response_format
branch
from
2dff6a7
to
9459f23
Compare
Co-authored-by: Will Barnes <will.t.barnes@gmail.com>
Co-authored-by: Will Barnes <will.t.barnes@gmail.com>
Co-authored-by: Will Barnes <will.t.barnes@gmail.com>
alasdairwilson
approved these changes
Mar 22, 2024
Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
nabobalis
added
Merge When CI Passes
nabobalis
commented
Mar 22, 2024
|
Thanks for the reviews @wtbarnes and @alasdairwilson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes: #7364
So during the 2.1 days we added this old response type to prevent some breaking changes from the rework of the metadata and we never got around to removing it.
So I have finally marked it as deprecated alongside some keywords that were unused.
This should not be backported.