Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes naxis update issue #7522

Merged
merged 5 commits into from Mar 24, 2024
Merged

Fixes naxis update issue #7522

merged 5 commits into from Mar 24, 2024

Conversation

Deus1704
Copy link
Contributor

PR Description

Fixes #7493

This PR makes the required changes to update the NAXIS correctly.

@Deus1704 Deus1704 requested a review from a team as a code owner March 22, 2024 23:39
@Deus1704
Copy link
Contributor Author

pre-commit.ci autofix

@nabobalis nabobalis added the map Affects the map submodule label Mar 22, 2024
@nabobalis nabobalis added Needs Review Needs reviews before merge backport 5.0 on-merge: backport to 5.0 backport 5.1 on-merge: backport to 5.1 labels Mar 22, 2024
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
@nabobalis nabobalis removed the Needs Review Needs reviews before merge label Mar 24, 2024
@nabobalis nabobalis merged commit d35cee0 into sunpy:main Mar 24, 2024
27 of 28 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/sunpy that referenced this pull request Mar 24, 2024
meeseeksmachine pushed a commit to meeseeksmachine/sunpy that referenced this pull request Mar 24, 2024
@nabobalis
Copy link
Contributor

Thanks again @Deus1704

nabobalis added a commit that referenced this pull request Mar 24, 2024
…2-on-5.1

Backport PR #7522 on branch 5.1 (Fixes naxis update issue)
nabobalis added a commit that referenced this pull request Mar 24, 2024
…2-on-5.0

Backport PR #7522 on branch 5.0 (Fixes naxis update issue)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 5.0 on-merge: backport to 5.0 backport 5.1 on-merge: backport to 5.1 map Affects the map submodule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map.rotate does not update NAXISi fields in the metadata
3 participants