Adds ValueError to mapbase.submap() when Helioprojection coordinate contains NaN values. #7543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inates contain NaN values. Added tests to test_mapbase.py.
nabobalis
reviewed
Apr 2, 2024
Comment on lines
+1998
to
+1999
| # If bottom_left or top_right is a helioprojective coordinate with NaN values, | ||
| # cannot create meaningful submap |
There was a problem hiding this comment.
Suggested change
| # If bottom_left or top_right is a helioprojective coordinate with NaN values, | |
| # cannot create meaningful submap |
nabobalis
reviewed
Apr 2, 2024
| # If bottom_left or top_right is a helioprojective coordinate with NaN values, | ||
| # cannot create meaningful submap | ||
| if (isinstance(bottom_left, Helioprojective)): | ||
| values = bottom_left.distance.to_value() |
There was a problem hiding this comment.
Are the values needed for anything else? If not, we could use the new walrus operator?
nabobalis
reviewed
Apr 2, 2024
| if (isinstance(bottom_left, Helioprojective)): | ||
| values = bottom_left.distance.to_value() | ||
| if np.isnan(values).any(): | ||
| raise ValueError("The Helioprojective coordinates input to `submap()` contain NaN values." |
There was a problem hiding this comment.
I think this message is the same as below? If so, I think defining it once above would be better.
nabobalis
reviewed
Apr 2, 2024
| h = Helioprojective([1,7]*u.arcsec*319, 0*u.arcsec, | ||
| observer='earth', obstime='2020-04-08') | ||
| h_3d = h.make_3d() | ||
| with pytest.raises(ValueError, match="contain NaN values."): |
There was a problem hiding this comment.
Can you make more of the message, maybe just the start of it instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request produces a value error when Helioprojection coordinates that have NaN distance values are input as bottom_left or top_right to the submap() function.
Relevant issue: #5598
Additional Info:
I'm unsure if this solution fully addresses the common user issue presented in #5598. A testcase that mimics one of these specific user issues could be useful to determine what other situations should result in the ValueError. Any suggestions would be greatly appreciated!