Migrate GenericMap to inherit from NDCube
#7547
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadair
commented
Apr 3, 2024
| """ | ||
| Returns PC matrix from the scale ration (lam) and rotation | ||
| angle in radians (angle). | ||
| def wcs(self): |
There was a problem hiding this comment.
I haven't moved wcs as it will be part of the refactoring.
Cadair
force-pushed
the
map_ndcube_migration
branch
from
fbc00e0
to
e902500
Compare
Cadair
force-pushed
the
map_ndcube_migration
branch
from
e902500
to
c772dff
Compare
Cadair
force-pushed
the
map_ndcube_migration
branch
2 times, most recently
from
d7ff851
to
52e083d
Compare
Cadair
commented
Apr 26, 2024
| # If the units are different to the original metadata then we override | ||
| # all the keys from the new WCS header to account for unit conversion. | ||
| if any([new_header[f"CUNIT{n}"] != self.meta[f"CUNIT{n}"] for n in range(1, 3)]): | ||
| # TODO: Do we want to make it so we don't change units? |
bug fix with nans in `test_rotate()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is made from a feature branch[1] which is going to form the core of the NDCube sprint work at the coordination meeting in a few weeks.
The first commit moves all the metadata model properties out on to a mixin class, as the plan is to not touch them during the refactor.
[1] oh wow it's been a while since we did this. EDIT FROM NABIL: NOT TRUE