Clean up util imports #7561
Merged
Clean up util imports #7561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I mean, that seems sensible yeah. |
|
We do need to deal with util. |
nabobalis
approved these changes
May 15, 2024
nabobalis
added
No Changelog Entry Needed
Minor Change
nabobalis
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will address #7560 but isn't really a "fix".
We need to be very careful with what we import at the top level inside
utilas we import it from the topsunpynamespace, and large import paths will slow that down and also occasionally cause weird issues (apparently).This is a quick fix, but I am unsure what we should do about this to make sure we keep the import hygiene in util?