Allow DN as a unit on GenericMap
#7585
Open
+39
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
added
map
Comment on lines
+1702
to
1735
| 10 * u.s, | ||
| u.Quantity([10], u.s), | ||
| u.Quantity(np.random.rand(128), u.s), | ||
| u.Quantity(np.random.rand(128, 128), u.s), | ||
| 10.0, |
There was a problem hiding this comment.
Why have ct changed to s? Rather than DN?
There was a problem hiding this comment.
Fair question. Because it seemed silly to be multiplying (or dividing) DN by something in ct
|
I approve of the principle of this PR. I think that this is a case of the FITS standard being insufficient, rather than solar physicists not adhering to that standard. We need DN. It is not the same as counts. |
|
The only tests I could not fix were the asdf ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6566