fix failing windows tests #7601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Scraper branch's windows tests had been failing since we were using
pathlib.Pathin the tests to send the directory path, which comes out with backslashes in windows fashion and would let us down when comparing with a forward-slashpattern. The way it's handled in main is we simply just don't usePath()to get OS-specific filepaths, and just linux style forward-slash strings. I've reverted it to match with main, though a discussion could be had if we should includepathlib.Pathgenerated paths there 馃Another error was because in one of the functions, scraper internally replaces \ with / in the pattern when in windows. I had previously replaced one of the two pattern variables and had missed the other one