Move simulation LOS intersection example to showcase section of example gallery #7610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtbarnes
added
No Changelog Entry Needed
Minor Change
nabobalis
added
the
No Backport
nabobalis
approved these changes
Apr 30, 2024
nabobalis
added a commit
that referenced
this pull request
May 26, 2024
* Clean up util imports * Fix a small bug in solar_frame_to_wcs_mapping Fix a small bug in solar_frame_to_wcs_mapping when dealing with custom subclasses. * Add failing test * Update code to pass test * Add change log Co-authored-by: Albert Y. Shih <ayshih@gmail.com> * move simulation LOS intersection example to showcase (#7610) * fix devdep test * fix si units * Doc test fixes? * Revert * moose * Update .github/workflows/ci.yml * new spelling * spelling * Fixed bug where convertion of results from the HEKClient to Astropy Time failed when some values where empty or missing * Added CHANGELOG * add quick unit test * Updated deprecated to use astropy underneath as we can pass in the warning type * Fix failing link (#7633) * Tidy up of the io docs and Api page * Fix tests and broken call * changelog * Update docs/reference/io.rst Co-authored-by: Will Barnes <will.t.barnes@gmail.com> * fix imports and tidy up * Add api docs to dev * silent ana * Fix doc build * Fix dep warning raising on incorrect imports * Fix actual import * actually fix it (#7622) * Remove unused and unsecure changelog items * Update sphinx gallery config to be valid now under new sphinx versions * precommit update [skip ci] (#7641) --------- Co-authored-by: Stuart Mumford <stuart@cadair.com> Co-authored-by: Shane Maloney <shane.maloney@dias.ie> Co-authored-by: Albert Y. Shih <ayshih@gmail.com> Co-authored-by: Will Barnes <will.t.barnes@gmail.com> Co-authored-by: Benjamin Mampaey <benjamin.mampaey@oma.be>
nabobalis
added a commit
that referenced
this pull request
May 26, 2024
* Clean up util imports * Fix a small bug in solar_frame_to_wcs_mapping Fix a small bug in solar_frame_to_wcs_mapping when dealing with custom subclasses. * Add failing test * Update code to pass test * Add change log Co-authored-by: Albert Y. Shih <ayshih@gmail.com> * move simulation LOS intersection example to showcase (#7610) * fix devdep test * fix si units * Doc test fixes? * Revert * moose * Update .github/workflows/ci.yml * new spelling * spelling * Fixed bug where convertion of results from the HEKClient to Astropy Time failed when some values where empty or missing * Added CHANGELOG * add quick unit test * Updated deprecated to use astropy underneath as we can pass in the warning type * Fix failing link (#7633) * Tidy up of the io docs and Api page * Fix tests and broken call * changelog * Update docs/reference/io.rst Co-authored-by: Will Barnes <will.t.barnes@gmail.com> * fix imports and tidy up * Add api docs to dev * silent ana * Fix doc build * Fix dep warning raising on incorrect imports * Fix actual import * actually fix it (#7622) * Remove unused and unsecure changelog items * Update sphinx gallery config to be valid now under new sphinx versions * precommit update [skip ci] (#7641) --------- Co-authored-by: Stuart Mumford <stuart@cadair.com> Co-authored-by: Shane Maloney <shane.maloney@dias.ie> Co-authored-by: Albert Y. Shih <ayshih@gmail.com> Co-authored-by: Will Barnes <will.t.barnes@gmail.com> Co-authored-by: Benjamin Mampaey <benjamin.mampaey@oma.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example is better suited for the showcase section.