Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving HEK Representation #7619

Draft
wants to merge 58 commits into
base: main
Choose a base branch
from
Draft

Improving HEK Representation #7619

wants to merge 58 commits into from

Conversation

ahmedhosssam
Copy link
Contributor

This PR includes the work that has been done in GSoC 23 but in a new and fresh branch to start GSoC 24.
I've migrated GSoC 23 commits and resolved most of the conflicts, it needs a review to see if there is any conflict remaining.

@nabobalis
Copy link
Contributor

You will need to add regions to https://github.com/sunpy/sunpy/blob/main/pyproject.toml#L77 so it is installed.

nabobalis
nabobalis reviewed May 13, 2024
View reviewed changes
sunpy/net/hek/hek.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed May 13, 2024
View reviewed changes
sunpy/net/hek/hek.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed May 13, 2024
View reviewed changes
sunpy/net/hek/hek.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed May 19, 2024
View reviewed changes
sunpy/net/hek/util.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed May 19, 2024
View reviewed changes
sunpy/net/hek/util.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed May 19, 2024
View reviewed changes
sunpy/net/hek/hek.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed May 19, 2024
View reviewed changes
sunpy/net/hek/util.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed May 19, 2024
View reviewed changes
sunpy/net/hek/util.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py
return tuple(freeze(elem) for elem in obj)
return obj

# NOTE: Needs unit test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still true?

nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py
]
return table

# NOTE: Needs unit test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still true?

nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py
table = parse_columns_to_table(table, coord_attributes, is_coord_prop = True)
return table

# NOTE: Needs unit test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still true?

nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py
Returns
-------
unit
Astropy unit object (e.g. <class 'astropy.units.core.Unit'> or <class 'astropy.units.core.CompositeUnit'>)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be linked using interlinks.

nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 20, 2024
View reviewed changes
sunpy/net/hek/utils.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabobalis nabobalis nabobalis left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahmedhosssam @nabobalis @aritrasinha108