LightCurve.meta now instance of OrderedDict #892
Conversation
| @@ -71,7 +72,11 @@ class LightCurve(object): | |||
|
|
|||
| def __init__(self, data, meta=None): | |||
| self.data = pandas.DataFrame(data) | |||
| self.meta = meta | |||
| if meta == '' or meta==None: | |||
There was a problem hiding this comment.
compare to the singleton None with is, not with ==.
|
@Cadair ,changes incorporated |
| @@ -100,6 +101,15 @@ def _parse_level_0cs(fp): | |||
| while line.startswith(";"): | |||
| header.append(line) | |||
| line = fp.readline() | |||
|
|
|||
| meta = OrderedDict() | |||
| for l in header : | |||
There was a problem hiding this comment.
is this 1 or l? I would change it for line so I can understand better what we are comparing.
|
I dont understand why does Travis build fails,help required |
|
@ehsteve @aringlis @wafels Is it my imagination of have GOES turned off their web services API? http://ngdc.noaa.gov/stp/satellite/goes/dataaccess.html |
|
Looks like you're right. I found the following message under 'what's new': 'The web services link will be removed from these web pages beginning today. There is an error that affects the date-time in returned data for two hours at the time of the spring daylight savings time each year. ' |
| @@ -69,9 +70,13 @@ class LightCurve(object): | |||
| _cond_dispatch = ConditionalDispatch() | |||
| create = classmethod(_cond_dispatch.wrapper()) | |||
|
|
|||
| def __init__(self, data, meta=None): | |||
| def __init__(self, data, meta = None): | |||
There was a problem hiding this comment.
PEP8: There should not be spaces around = for keywords.
|
After the small PEP8 fix, could you please add a changelog entry and then I would be good for merge. |
|
Made the changes |
|
you seem to have missed my |
|
done |
|
👍 Looks great |
LightCurve.meta now instance of OrderedDict
hopefully solved
#841
Lightcurve.Meta now ensured to be instance of OrderedDict ,essentially having
.copy()method ,solving the error in Truncate function,