Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better userspace error handling #48

Merged
merged 3 commits into from
Dec 3, 2018
Merged

Better userspace error handling #48

merged 3 commits into from
Dec 3, 2018

Conversation

roblabla
Copy link
Member

@roblabla roblabla commented Dec 3, 2018

  • Move kernel UserspaceError to libkern KernelError
  • Create a libuser::error::Error type, strongly typing all the errors.
  • Make all the libuser syscalls return a KernelError type
  • Make all the wrapper return a fat Error type.

@sunriseos sunriseos deleted a comment from todo bot Dec 3, 2018
@sunriseos sunriseos deleted a comment from todo bot Dec 3, 2018
@roblabla
Better userspace error handling
6c74a30 
- Move kernel UserspaceError to libkern KernelError
- Create a libuser::error::Error type, strongly typing all the errors.
- Make all the libuser syscalls return a KernelError type
- Make all the wrapper return a fat Error type.
@todo
Copy link

todo bot commented Dec 3, 2018

Better Display implementation for libuser::Error

Right now, the libuser::Error Display just shims back to the Debug implementation.

https://github.com/roblabla42/KFS/blob/6c74a304df77a9ed9bcefa29191524ae08e22f51/libuser/src/error.rs#L30-L40

This comment was generated by todo based on a TODO comment in 6c74a30 in #48. cc @roblabla.

@roblabla roblabla mentioned this pull request Dec 3, 2018
Closed
@todo
Copy link

todo bot commented Dec 3, 2018

Object Macro: Take Error type as $ty

We currently match the Error token exactly, which is overly restrictive.

https://github.com/roblabla42/KFS/blob/72768fb215755c2afa528e9f5a7838dc5cc36cb0/libuser/src/ipc/macros.rs#L98-L104

This comment was generated by todo based on a TODO comment in 72768fb in #48. cc @roblabla.

@Orycterope Orycterope merged commit bc95748 into sunriseos:master Dec 3, 2018
This was referenced Dec 3, 2018
Open
Closed
This was referenced Dec 4, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Orycterope Orycterope Orycterope approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roblabla @Orycterope