Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExtendedDismaxParser support #371

Closed
wants to merge 1 commit into from

Conversation

diebels727
Copy link

Now that Solr 3.5 is in the mix, I independently implemented support for the edismax parser, which is eerily similar to the implementation described in Issue #93.

I still have a failing test regarding the dynamic_fields shared examples; I believe this is a result of some of the wizardry I am attempting to do reuse the shared examples in the tests for edismax.

@tadast tadast mentioned this pull request Jul 8, 2013
@rywall rywall mentioned this pull request Oct 25, 2013
@njakobsen
Copy link
Contributor

Closed by #487 because Sunspot now uses edismax. We incorporated your edismax tests in #488. We took the easy route this time, but we'll see if there's a reason to support both in the future, at which point we may revisit this pull request. Thanks for the help!

@njakobsen njakobsen closed this Oct 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants