Add auto_index_callback and auto_remove_callback config option #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Auto index and auto removal can now be done in the after_commit callback in Rails 3, which is a better option in general because the transaction will have been finished. * Since switching to after_commit might be a breaking change for some (especially in tests), it was decided to add a config option that defaults to after_save.
Requested as per sunspot#532
njakobsen
added a commit
that referenced
this pull request
Mar 22, 2015
Add auto_index_callback and auto_remove_callback config option
|
Thanks! I think #534 can be closed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of #249 which was merged into the 1-3-stable
callback in Rails 3, which is a better option in general because the
transaction will have been finished.
(especially in tests), it was decided to add a config option that
defaults to after_save.