Generic pagination support #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ref pull request for notes #64 |
|
Looks good -- I don't really see any holes in the test coverage. But every time a Ruby method header is defined with non-zero arguments and no parentheses, a kitten dies. Can you fix? I like kittens. |
|
Haha! Done. |
|
I was really waiting for this one, great work lardawge. |
|
Nick is working on putting together a 1.3 release which should come out soon. Feel free to pipe up on the mailing list if you'd like to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial run through.
I still would like to add more tests in hits_spec.rb and results_spec.rb but it might not be necessary.
I would also like to have some peep test it in running apps just to double check I didn't miss anything.