Generic pagination support #67

Merged
merged 7 commits into from Jun 28, 2011

Conversation

Projects
None yet
3 participants
Contributor

lardawge commented Jun 28, 2011

Initial run through.

I still would like to add more tests in hits_spec.rb and results_spec.rb but it might not be necessary.
I would also like to have some peep test it in running apps just to double check I didn't miss anything.

Contributor

lardawge commented Jun 28, 2011

Ref pull request for notes #64

Owner

outoftime commented Jun 28, 2011

Looks good -- I don't really see any holes in the test coverage. But every time a Ruby method header is defined with non-zero arguments and no parentheses, a kitten dies. Can you fix? I like kittens.

Contributor

lardawge commented Jun 28, 2011

Haha! Done.

@outoftime outoftime added a commit that referenced this pull request Jun 28, 2011

@outoftime outoftime Merge pull request #67 from lardawge/generic_pagination_support
Generic pagination support
08dc66b

@outoftime outoftime merged commit 08dc66b into sunspot:master Jun 28, 2011

I was really waiting for this one, great work lardawge.
Any clue when we can expect a push to the gem? Last update was in December 2010.

Owner

outoftime commented Jul 1, 2011

Nick is working on putting together a 1.3 release which should come out soon. Feel free to pipe up on the mailing list if you'd like to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment