Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow geofilt searches to be negated. Fixes #363. #878

Merged
merged 2 commits into from
Mar 5, 2019
Merged

Allow geofilt searches to be negated. Fixes #363. #878

merged 2 commits into from
Mar 5, 2019

Conversation

heaven
Copy link
Contributor

@heaven heaven commented Jan 3, 2018

InRadius has a few additional parameters which prevented #negate from working properly with it.

@heaven
Copy link
Contributor Author

heaven commented Jan 3, 2018

Hi @njakobsen, can you please review and merge?

@njakobsen
Copy link
Contributor

Looks good. Though what would really put the polish on this PR is a set of tests for the behaviour you've added.

@heaven
Copy link
Contributor Author

heaven commented Jan 4, 2018

Done.

@njakobsen
Copy link
Contributor

Do you mind looking into the test failures?

@heaven
Copy link
Contributor Author

heaven commented Jan 4, 2018

They look unrelated to this change.

@njakobsen
Copy link
Contributor

K. I'm going to leave this for @bragboy or one of the other more recent maintainers to merge. I've been away from active development on this project for quite some time.

@heaven
Copy link
Contributor Author

heaven commented Jan 4, 2018

Started failing after #873

@heaven
Copy link
Contributor Author

heaven commented Jan 4, 2018

Failed examples related to :random ordering, one of them has (run this test again if it fails).

@serggl
Copy link
Collaborator

serggl commented Mar 25, 2018

@heaven please rebase this branch against master, we can merge this once tests will pass

@heaven
Copy link
Contributor Author

heaven commented Mar 5, 2019

@serggl, done (hopefully :))

@bragboy bragboy merged commit ba66397 into sunspot:master Mar 5, 2019
@heaven heaven deleted the negated-geofilt branch March 5, 2019 14:33
serggl added a commit that referenced this pull request Jul 5, 2019
@serggl
[ci skip] bump gem version to accomodate #886, #878, #944, #941, #930, …
87ec0aa 
…#936, #927, #923, #921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njakobsen njakobsen njakobsen approved these changes

Assignees

@bragboy bragboy

Labels
awaiting-feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@heaven @njakobsen @serggl @bragboy