Ability to set group.ngroups option #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serggl
reviewed
Nov 6, 2018
.travis.yml
Outdated
| before_install: gem install bundler | ||
| before_install: | ||
| - gem install bundler | ||
| - gem install psych -v 2.2.4 |
There was a problem hiding this comment.
@giovannelli can you explain why was this required?
|
looks great. I found only one question about |
|
Hi @serggl, Probably it was related to the concurrent-ruby version 1.1.1, they have just released a newer version. Thank you |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
by default the Sunspot::Query::Group.to_params method has the group.ngroups option set to "true". If you don't need the total groups counter, ngroups=false increases performances, here's why we've added this option. Paginated collections return wrong values for total_pages, total_count and last_page? if ngroups is false.
Thank you,
Duccio