Documentation changes (esp. reference.rst) additional __getitem__() function (object.__getattribute__()) for netParams and simConfig. #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now can do nested __getitem__ calls should netParams and simConfig inherit from some dictionary class?
added documentation
point cell documentation
specifically -- 'spikePattern': {'type': # 'rhythmic', 'evoked', 'poisson', 'gauss' ...}
see doc/source/reference.rst
updated pointCell.py documentation
netpyne/network/stim.py refers to netpyne/cell/pointCell.py netpyne/network/pop.py has 'xRange', 'yRange', 'zRange' explicitly named to avoid confusion
|
Documentation update: -- documentation to 'xRange', 'yRange', 'zRange' to netpyne/network/pop.py (to find handler for those parameters) -- by adding |
pgleeson
added a commit
that referenced
this pull request
Mar 29, 2023
* neuroml_updates: (84 commits) Ignore arm64 folders as generated by NEURON on recent apple mac chips Clean metadata.py file Fix faulty entries from metadata.py file added utility script to run over all examples and validate netParams. cleaned up most of validation errors identified Documentation changes (esp. reference.rst) for complex stimulation. Additional __getitem__() function (object.__getattribute__()) for netParams and simConfig. (#743) make M1Detailed example load from index file fixed handling filenames with multiple dots in MetaFigure.saveFig() handle 'mech already exists' error when loading model Update dipole.py More tests updated Add some updated tests unit tests for saveModel API modified saveModel API to support Python3.7 (and also, with this change, method now force-removes dstDir if it already exists) save model in new format. adapted code of generating python script to be able to export netParams and cfg separately revert default args in readCmdLimeArgs() to keep backward-compatibility set validateNetParams to True by default More info on python package versions in tests Regenerated nml files Changes to netpyne/batch/utils.py to make OS agnostic added schema cross-validation, validation of mechanisms (except mech params), cleaned-up some netParams for which validation failed ...
pgleeson
added a commit
that referenced
this pull request
Mar 29, 2023
* neuroml_updates: (384 commits) Ignore arm64 folders as generated by NEURON on recent apple mac chips Clean metadata.py file Fix faulty entries from metadata.py file added utility script to run over all examples and validate netParams. cleaned up most of validation errors identified Documentation changes (esp. reference.rst) for complex stimulation. Additional __getitem__() function (object.__getattribute__()) for netParams and simConfig. (#743) make M1Detailed example load from index file fixed handling filenames with multiple dots in MetaFigure.saveFig() handle 'mech already exists' error when loading model Update dipole.py More tests updated Add some updated tests unit tests for saveModel API modified saveModel API to support Python3.7 (and also, with this change, method now force-removes dstDir if it already exists) save model in new format. adapted code of generating python script to be able to export netParams and cfg separately revert default args in readCmdLimeArgs() to keep backward-compatibility set validateNetParams to True by default More info on python package versions in tests Regenerated nml files Changes to netpyne/batch/utils.py to make OS agnostic added schema cross-validation, validation of mechanisms (except mech params), cleaned-up some netParams for which validation failed ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added documentation to doc/source/reference.rst netpyne/cell/pointCell.py and netpyne/network/stim.py regarding patterned VecStim creation.
by adding getitem() function for netParams and simConfig, allows for simpler crawling through each parameter dictionary through sequential calls to getitem() . (call through object.getattribute(self, ...) )