Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OFFSET #167

Closed
wants to merge 7 commits into from
Closed

Add OFFSET #167

wants to merge 7 commits into from

Conversation

gijsaddas
Copy link

Introduces OFFSET argument when using the LIMIT function

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 21, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.16%.

Quality metrics Before After Change
Complexity 1.18 ⭐ 1.16 ⭐ -0.02 👍
Method Length 35.71 ⭐ 35.46 ⭐ -0.25 👍
Working memory 5.90 ⭐ 5.87 ⭐ -0.03 👍
Quality 85.74% 85.90% 0.16% 👍
Other metrics Before After Change
Lines 360 371 11
Changed files Quality Before Quality After Quality Change
postgrest/base_request_builder.py 85.74% ⭐ 85.90% ⭐ 0.16% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@J0
Copy link
Contributor

J0 commented Jan 23, 2023

Hey!

Wanted to check in on the PR - is the setup.py file needed? Otherwise it seems fine to me - might want to consider merging in the Sorcery refactoring

@deleted
Copy link

deleted commented Oct 19, 2023

Hey, this seems like a pretty useful addition to the API. Just wanted to check in on what the status of merging it. (Looks to me like the setup.py could be removed completely since a pyproject.toml exists).

If you came here just looking for a way to do pagination, be advised that a range() method also exists on the query builder, though beware that it decrements its end parameter before emitting the header for some reason:

def range(self: _FilterT, start: int, end: int) -> _FilterT:

@J0
Copy link
Contributor

J0 commented Oct 20, 2023

@deleted I'll make the changes and merge it if there's no update by end of day UTC. I do sometimes lose track though - so feel free to bump if I don't get back by then.

@J0 J0 mentioned this pull request Oct 21, 2023
2 tasks
@J0
Copy link
Contributor

J0 commented Oct 22, 2023

Merged in via #326

thanks for the contribution!

@J0 J0 closed this Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants