Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add offset #326

Merged
merged 1 commit into from
Oct 22, 2023
Merged

feat: add offset #326

merged 1 commit into from
Oct 22, 2023

Conversation

J0
Copy link
Contributor

@J0 J0 commented Oct 21, 2023

What kind of change does this PR introduce?

Patch the add offset pr in #167 since it seems stale

To test this do: res = supabase.from_("countries").select("*").limit(5).offset(3).execute() on the default countries table. You should see that there are 5 entries starting from index 4.

TODO:

  • Update Docs
  • Test

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (193c8df) 91.62% compared to head (d9dc84f) 91.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
- Coverage   91.62%   91.48%   -0.14%     
==========================================
  Files          24       24              
  Lines        1253     1256       +3     
==========================================
+ Hits         1148     1149       +1     
- Misses        105      107       +2     
Files Coverage Δ
postgrest/base_request_builder.py 77.63% <33.33%> (-0.60%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@silentworks silentworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@J0 J0 merged commit 7cd6751 into master Oct 22, 2023
13 of 15 checks passed
@J0 J0 deleted the J0/patch_add_offset branch October 22, 2023 05:40
@J0 J0 mentioned this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants