Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use cookie name as storage key #730

Merged
merged 2 commits into from Jan 30, 2024
Merged

fix: use cookie name as storage key #730

merged 2 commits into from Jan 30, 2024

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

  • Currently, setting a custom cookie name via the cookieOptions breaks the client because the cookies will be set with the custom name but getItem uses the storageKey value to retrieve the cookie

@kangmingtay kangmingtay requested a review from a team January 26, 2024 10:04
@kangmingtay kangmingtay merged commit 8ed42ff into main Jan 30, 2024
3 checks passed
@kangmingtay kangmingtay deleted the km/fix-ssr-custom-cookie-name branch January 30, 2024 02:26
This was referenced Jan 31, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hf hf hf approved these changes

@J0 J0 J0 approved these changes

@dijonmusters dijonmusters Awaiting requested review from dijonmusters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kangmingtay @hf @J0