Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate signup link should not error #1514

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

kangmingtay
Copy link
Member

@kangmingtay kangmingtay commented Apr 3, 2024

What kind of change does this PR introduce?

  • Fixes an error introduced in feat: add error codes #1377 where generating a signup link for a new user results in a "User with this email not found" error

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

@kangmingtay kangmingtay requested a review from a team as a code owner April 3, 2024 08:52
@kangmingtay kangmingtay merged commit 4fc3881 into master Apr 3, 2024
4 checks passed
@kangmingtay kangmingtay deleted the km/fix-signup-generate-link branch April 3, 2024 09:02
kangmingtay pushed a commit that referenced this pull request Apr 3, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.146.0](v2.145.0...v2.146.0)
(2024-04-03)


### Features

* add custom sms hook
([#1474](#1474))
([0f6b29a](0f6b29a))
* forbid generating an access token without a session
([#1504](#1504))
([795e93d](795e93d))


### Bug Fixes

* add cleanup statement for anonymous users
([#1497](#1497))
([cf2372a](cf2372a))
* generate signup link should not error
([#1514](#1514))
([4fc3881](4fc3881))
* move all EmailActionTypes to mailer package
([#1510](#1510))
([765db08](765db08))
* refactor mfa and aal update methods
([#1503](#1503))
([31a5854](31a5854))
* rename from CustomSMSProvider to SendSMS
([#1513](#1513))
([c0bc37b](c0bc37b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8535912117

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 65.346%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/mail.go 0 1 0.0%
Totals Coverage Status
Change from base Build 8535318020: 0.2%
Covered Lines: 8050
Relevant Lines: 12319

💛 - Coveralls

dagingaa added a commit to dagingaa/cli that referenced this pull request Apr 22, 2024
GoTrue version 2.145.0 has a bug where generating a signup link will fail with "user_not_found", which was fixed in 2.146.0 (supabase/auth#1514). Since 2.145.0 is locked in the CLI, we can't get the bug fix out.

This PR updates the image to 2.149.0 which is the most recent version as of 2024-04-22 so the signup link generation works again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants