Skip to content

fix: add cleanup statement for anonymous users #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 27, 2024
Merged

fix: add cleanup statement for anonymous users #1497

merged 4 commits into from
Mar 27, 2024

Conversation

@kangmingtay
Copy link
Member

What kind of change does this PR introduce?

  • Adds a cleanup statement to delete anonymous users older than 30 days
  • Runs only if anonymous sign-ins are enabled
  • Move cleanup struct creation into Setup function

@kangmingtay kangmingtay requested a review from a team as a code owner March 26, 2024 12:27
J0
J0 reviewed Mar 26, 2024
View reviewed changes
@kangmingtay @J0
Update internal/models/cleanup.go
14ef2be 
Co-authored-by: Joel Lee <lee.yi.jie.joel@gmail.com>
@kangmingtay kangmingtay force-pushed the km/cleanup-anonymous-users branch from f366d11 to cd543ac Compare March 27, 2024 06:39
@kangmingtay kangmingtay force-pushed the km/cleanup-anonymous-users branch from cd543ac to 615926b Compare March 27, 2024 06:40
@coveralls
Copy link

coveralls commented Mar 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8447706448

Details

  • 16 of 17 (94.12%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 65.165%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/api.go 0 1 0.0%
Totals Coverage Status
Change from base Build 8447621698: 0.06%
Covered Lines: 8042
Relevant Lines: 12341
💛 - Coveralls

@kangmingtay kangmingtay merged commit cf2372a into master Mar 27, 2024
@kangmingtay kangmingtay deleted the km/cleanup-anonymous-users branch March 27, 2024 10:55
@github-actions github-actions bot mentioned this pull request Mar 27, 2024
Merged
J0 added a commit that referenced this pull request Apr 1, 2024
@kangmingtay @J0
fix: add cleanup statement for anonymous users (#1497)
dfddff4 
## What kind of change does this PR introduce?
* Adds a cleanup statement to delete anonymous users older than 30 days
* Runs only if anonymous sign-ins are enabled
* Move cleanup struct creation into Setup function

---------

Co-authored-by: Joel Lee <lee.yi.jie.joel@gmail.com>
kangmingtay pushed a commit that referenced this pull request Apr 3, 2024
@github-actions
chore(master): release 2.146.0 (#1499)
8002ccb 
🤖 I have created a release *beep* *boop*
---


##
[2.146.0](v2.145.0...v2.146.0)
(2024-04-03)


### Features

* add custom sms hook
([#1474](#1474))
([0f6b29a](0f6b29a))
* forbid generating an access token without a session
([#1504](#1504))
([795e93d](795e93d))


### Bug Fixes

* add cleanup statement for anonymous users
([#1497](#1497))
([cf2372a](cf2372a))
* generate signup link should not error
([#1514](#1514))
([4fc3881](4fc3881))
* move all EmailActionTypes to mailer package
([#1510](#1510))
([765db08](765db08))
* refactor mfa and aal update methods
([#1503](#1503))
([31a5854](31a5854))
* rename from CustomSMSProvider to SendSMS
([#1513](#1513))
([c0bc37b](c0bc37b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@kangmingtay @J0
fix: add cleanup statement for anonymous users (supabase#1497)
518a26a 
## What kind of change does this PR introduce?
* Adds a cleanup statement to delete anonymous users older than 30 days
* Runs only if anonymous sign-ins are enabled
* Move cleanup struct creation into Setup function

---------

Co-authored-by: Joel Lee <lee.yi.jie.joel@gmail.com>
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@github-actions
chore(master): release 2.146.0 (supabase#1499)
b8f31d7 
🤖 I have created a release *beep* *boop*
---


##
[2.146.0](supabase/auth@v2.145.0...v2.146.0)
(2024-04-03)


### Features

* add custom sms hook
([supabase#1474](supabase#1474))
([0f6b29a](supabase@0f6b29a))
* forbid generating an access token without a session
([supabase#1504](supabase#1504))
([795e93d](supabase@795e93d))


### Bug Fixes

* add cleanup statement for anonymous users
([supabase#1497](supabase#1497))
([cf2372a](supabase@cf2372a))
* generate signup link should not error
([supabase#1514](supabase#1514))
([4fc3881](supabase@4fc3881))
* move all EmailActionTypes to mailer package
([supabase#1510](supabase#1510))
([765db08](supabase@765db08))
* refactor mfa and aal update methods
([supabase#1503](supabase#1503))
([31a5854](supabase@31a5854))
* rename from CustomSMSProvider to SendSMS
([supabase#1513](supabase#1513))
([c0bc37b](supabase@c0bc37b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@kangmingtay @J0 @LashaJini
fix: add cleanup statement for anonymous users (supabase#1497)
4cdbb49 
## What kind of change does this PR introduce?
* Adds a cleanup statement to delete anonymous users older than 30 days
* Runs only if anonymous sign-ins are enabled
* Move cleanup struct creation into Setup function

---------

Co-authored-by: Joel Lee <lee.yi.jie.joel@gmail.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@github-actions @LashaJini
chore(master): release 2.146.0 (supabase#1499)
fae14d3 
🤖 I have created a release *beep* *boop*
---


##
[2.146.0](supabase/auth@v2.145.0...v2.146.0)
(2024-04-03)


### Features

* add custom sms hook
([supabase#1474](supabase#1474))
([0f6b29a](supabase@0f6b29a))
* forbid generating an access token without a session
([supabase#1504](supabase#1504))
([795e93d](supabase@795e93d))


### Bug Fixes

* add cleanup statement for anonymous users
([supabase#1497](supabase#1497))
([cf2372a](supabase@cf2372a))
* generate signup link should not error
([supabase#1514](supabase#1514))
([4fc3881](supabase@4fc3881))
* move all EmailActionTypes to mailer package
([supabase#1510](supabase#1510))
([765db08](supabase@765db08))
* refactor mfa and aal update methods
([supabase#1503](supabase#1503))
([31a5854](supabase@31a5854))
* rename from CustomSMSProvider to SendSMS
([supabase#1513](supabase#1513))
([c0bc37b](supabase@c0bc37b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
@kangmingtay @J0 @LashaJini
fix: add cleanup statement for anonymous users (supabase#1497)
108d58e 
## What kind of change does this PR introduce?
* Adds a cleanup statement to delete anonymous users older than 30 days
* Runs only if anonymous sign-ins are enabled
* Move cleanup struct creation into Setup function

---------

Co-authored-by: Joel Lee <lee.yi.jie.joel@gmail.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
@github-actions @LashaJini
chore(master): release 2.146.0 (supabase#1499)
62cc5ed 
🤖 I have created a release *beep* *boop*
---


##
[2.146.0](supabase/auth@v2.145.0...v2.146.0)
(2024-04-03)


### Features

* add custom sms hook
([supabase#1474](supabase#1474))
([0f6b29a](supabase@0f6b29a))
* forbid generating an access token without a session
([supabase#1504](supabase#1504))
([795e93d](supabase@795e93d))


### Bug Fixes

* add cleanup statement for anonymous users
([supabase#1497](supabase#1497))
([cf2372a](supabase@cf2372a))
* generate signup link should not error
([supabase#1514](supabase#1514))
([4fc3881](supabase@4fc3881))
* move all EmailActionTypes to mailer package
([supabase#1510](supabase#1510))
([765db08](supabase@765db08))
* refactor mfa and aal update methods
([supabase#1503](supabase#1503))
([31a5854](supabase@31a5854))
* rename from CustomSMSProvider to SendSMS
([supabase#1513](supabase#1513))
([c0bc37b](supabase@c0bc37b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cemalkilic pushed a commit that referenced this pull request Aug 7, 2025
@kangmingtay @J0 @cemalkilic
fix: add cleanup statement for anonymous users (#1497)
9a4cedf 
## What kind of change does this PR introduce?
* Adds a cleanup statement to delete anonymous users older than 30 days
* Runs only if anonymous sign-ins are enabled
* Move cleanup struct creation into Setup function

---------

Co-authored-by: Joel Lee <lee.yi.jie.joel@gmail.com>
cemalkilic pushed a commit that referenced this pull request Aug 7, 2025
@github-actions @cemalkilic
chore(master): release 2.146.0 (#1499)
16c8eaf 
🤖 I have created a release *beep* *boop*
---


##
[2.146.0](v2.145.0...v2.146.0)
(2024-04-03)


### Features

* add custom sms hook
([#1474](#1474))
([0f6b29a](0f6b29a))
* forbid generating an access token without a session
([#1504](#1504))
([795e93d](795e93d))


### Bug Fixes

* add cleanup statement for anonymous users
([#1497](#1497))
([cf2372a](cf2372a))
* generate signup link should not error
([#1514](#1514))
([4fc3881](4fc3881))
* move all EmailActionTypes to mailer package
([#1510](#1510))
([765db08](765db08))
* refactor mfa and aal update methods
([#1503](#1503))
([31a5854](31a5854))
* rename from CustomSMSProvider to SendSMS
([#1513](#1513))
([c0bc37b](c0bc37b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
xeladotbe pushed a commit to xeladotbe/supabase-auth that referenced this pull request Sep 27, 2025
@kangmingtay @J0 @xeladotbe
fix: add cleanup statement for anonymous users (supabase#1497)
0281d8e 
## What kind of change does this PR introduce?
* Adds a cleanup statement to delete anonymous users older than 30 days
* Runs only if anonymous sign-ins are enabled
* Move cleanup struct creation into Setup function

---------

Co-authored-by: Joel Lee <lee.yi.jie.joel@gmail.com>
xeladotbe pushed a commit to xeladotbe/supabase-auth that referenced this pull request Sep 27, 2025
@github-actions @xeladotbe
chore(master): release 2.146.0 (supabase#1499)
d701fcb 
🤖 I have created a release *beep* *boop*
---


##
[2.146.0](supabase/auth@v2.145.0...v2.146.0)
(2024-04-03)


### Features

* add custom sms hook
([supabase#1474](supabase#1474))
([0f6b29a](supabase@0f6b29a))
* forbid generating an access token without a session
([supabase#1504](supabase#1504))
([795e93d](supabase@795e93d))


### Bug Fixes

* add cleanup statement for anonymous users
([supabase#1497](supabase#1497))
([cf2372a](supabase@cf2372a))
* generate signup link should not error
([supabase#1514](supabase#1514))
([4fc3881](supabase@4fc3881))
* move all EmailActionTypes to mailer package
([supabase#1510](supabase#1510))
([765db08](supabase@765db08))
* refactor mfa and aal update methods
([supabase#1503](supabase#1503))
([31a5854](supabase@31a5854))
* rename from CustomSMSProvider to SendSMS
([supabase#1513](supabase#1513))
([c0bc37b](supabase@c0bc37b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
issuedat pushed a commit that referenced this pull request Sep 30, 2025
@kangmingtay @J0 @issuedat
fix: add cleanup statement for anonymous users (#1497)
11f3430 
## What kind of change does this PR introduce?
* Adds a cleanup statement to delete anonymous users older than 30 days
* Runs only if anonymous sign-ins are enabled
* Move cleanup struct creation into Setup function

---------

Co-authored-by: Joel Lee <lee.yi.jie.joel@gmail.com>
issuedat pushed a commit that referenced this pull request Sep 30, 2025
@github-actions @issuedat
chore(master): release 2.146.0 (#1499)
8124173 
🤖 I have created a release *beep* *boop*
---


##
[2.146.0](v2.145.0...v2.146.0)
(2024-04-03)


### Features

* add custom sms hook
([#1474](#1474))
([0f6b29a](0f6b29a))
* forbid generating an access token without a session
([#1504](#1504))
([795e93d](795e93d))


### Bug Fixes

* add cleanup statement for anonymous users
([#1497](#1497))
([cf2372a](cf2372a))
* generate signup link should not error
([#1514](#1514))
([4fc3881](4fc3881))
* move all EmailActionTypes to mailer package
([#1510](#1510))
([765db08](765db08))
* refactor mfa and aal update methods
([#1503](#1503))
([31a5854](31a5854))
* rename from CustomSMSProvider to SendSMS
([#1513](#1513))
([c0bc37b](c0bc37b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@J0 J0 J0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kangmingtay @coveralls @J0