Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add session_id to refresh_tokens table #600

Merged
merged 9 commits into from
Aug 24, 2022

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

  • Add a session_id column to the refresh_tokens table to keep track of a group of refresh_tokens that belong to the same session

@kangmingtay kangmingtay requested review from hf and J0 August 11, 2022 16:31
@kangmingtay kangmingtay self-assigned this Aug 11, 2022
Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can consider adding tests for the sessions model in the future

@kangmingtay kangmingtay changed the title [WIP] fix: add session_id to refresh_tokens table fix: add session_id to refresh_tokens table Aug 24, 2022
Copy link
Contributor

@hf hf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally OK, some tiny things to consider but doable in another PR.

models/sessions.go Show resolved Hide resolved
api/token.go Show resolved Hide resolved
@kangmingtay kangmingtay merged commit f427b9f into master Aug 24, 2022
@kangmingtay kangmingtay deleted the km/fix-add-session-id branch August 24, 2022 19:27
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.15.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants