feat: add PKCE (OAuth) #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
reviewed
Jan 30, 2023
hf
reviewed
Jan 30, 2023
hf
reviewed
Jan 30, 2023
added 21 commits
January 31, 2023 16:37
hf
reviewed
Mar 15, 2023
hf
reviewed
Mar 15, 2023
hf
reviewed
Mar 15, 2023
hf
reviewed
Mar 15, 2023
Co-authored-by: Stojan Dimitrovski <sdimitrovski@gmail.com>
|
@J0 Can you please change the timestamp of the migration to be closer to today and also work with @kangmingtay to get this merged this week? |
|
@hf sure, let's change the migration timestamp at the end, once we are sure there are no further changes. I'll self review today and we can each do a final pass. Once we're all happy with where we're at with the PR we can merge. Upd: updated the timestamp |
kangmingtay
approved these changes
Mar 24, 2023
|
Thanks for the refactors! The code is cleaner to read now. Going to merge |
|
🎉 This PR is included in version 2.55.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
J0
added a commit
to supabase/auth-js
that referenced
this pull request
Mar 29, 2023
The corresponding client side implementation for: supabase/auth#891 Points of note: - We don't support `plain` as a method on the client side for now. Users can make use of `plain` on the server side endpoints if they wish. TODO: - [x] Add support for devices without a `window` After PR: - Update reference spec with example on how to use PKCE --------- Co-authored-by: joel@joellee.org <joel@joellee.org> Co-authored-by: Stojan Dimitrovski <sdimitrovski@gmail.com> Co-authored-by: Kang Ming <kang.ming1996@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds POC for PKCE on Server Side.
Key points
userIDonoauthStateis not set as a foreign key as it is not set until the identity is created in the callback. Therefore, it could be null and is not set as a foreign key.What is the current behavior?
We use the implicit flow.
What is the new behavior?
We will use the PKCE flow.
Additional context
You may wish to view the end to end test on
external_github_test.gobefore looking into the detailsShort demo: https://share.cleanshot.com/Rf3bPR6t