Skip to content

Commit

Permalink
fix: identified and fixed a memory leak from JsRuntime
Browse files Browse the repository at this point in the history
I had to use the cargo patch to fix the memory leakage problem because the root
cause of the memory leak belonged to `deno_core`.

Eventually, these changes should be tracked at `deno_core`; so until fixing this
problem upstream, we have to use the patch.

It could be the substantial solution for #212 and
#192 (on the assumption that I found all memory leakage
places of `JsRuntime` 😋 For reference, Valgrind no longer reported definite
memory leakage after this patch)

(cherry picked from commit bc631b4)
  • Loading branch information
nyannyacha committed Jan 20, 2024
1 parent b9268ad commit 93ee272
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
2 changes: 2 additions & 0 deletions .cargo/config.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[env]
RUSTY_V8_MIRROR = "https://github.com/nyannyacha/rusty_v8/releases/download"
13 changes: 6 additions & 7 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ futures-util = { version = "0.3.28" }

[patch.crates-io]
deno_core = { git = "https://github.com/nyannyacha/deno_core", branch = "222" }
v8 = { git = "https://github.com/nyannyacha/rusty_v8", branch = "rokat" }

[profile.release]
lto = true

0 comments on commit 93ee272

Please sign in to comment.