fix: Identified and fixed a memory leak from JsRuntime
#240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you opened PRs for |
This was referenced Jan 10, 2024
(cherry picked from commit 3be0d0d)
I had to use the cargo patch to fix the memory leakage problem because the root cause of the memory leak belonged to `deno_core`. Eventually, these changes should be tracked at `deno_core`; so until fixing this problem upstream, we have to use the patch. It could be the substantial solution for supabase#212 and supabase#192 (on the assumption that I found all memory leakage places of `JsRuntime` 😋 For reference, Valgrind no longer reported definite memory leakage after this patch) (cherry picked from commit bc631b4)
This commit reflects upstream dependency changes that turn off the submodule update. (cherry picked from commit 4089d22)
nyannyacha
force-pushed
the
fix-mem-leak
branch
from
6d47cc2
to
585578f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
Description
This PR fixes the memory leakage from
JsRuntime.I've already written some commits to the upstream fork to fix the memory leak problem.
The PR brings in that fork using the cargo patch12.
CAVEATS: PR makes
edge-runtimedepend on the my upstream fork. If you have a plan that will manage upstream changes manually, it would make sense for the Supabase team to take my fork to your org repo first.Resolves #212
cc @laktek
😋
Footnotes
https://github.com/nyannyacha/rusty_v8/tree/rokat ↩
https://github.com/nyannyacha/deno_core/tree/222 ↩