Revert "feat: use DuplexStream instead of UnixStream to communicate with workers
#326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te with workers (supabase#320)" This reverts commit 4e53e2a. # Conflicts: # crates/base/src/server.rs # crates/cli/src/main.rs
nyannyacha
force-pushed
the
revert-perf-req
branch
from
ed62968
to
04a32f7
Compare
laktek
approved these changes
Apr 22, 2024
|
Will have to prefix the revert commit as a |
nyannyacha
changed the title
DuplexStream instead of UnixStream to communicate with workersDuplexStream instead of UnixStream to communicate with workers
nyannyacha
changed the title
DuplexStream instead of UnixStream to communicate with workersDuplexStream instead of UnixStream to communicate with workers
|
🎉 This PR is included in version 1.46.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Revert commit
Description
An unexpected pipe closure behavior for
DuplexStreamthat differed fromUnixStreamcaused a regression in connection lifetime tracking behavior.Revert the change until this issue is resolved.