This repository has been archived by the owner on May 13, 2023. It is now read-only.
fix: prevent AuthState signedIn with null session #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If _notifyAllSubscribers is called before _saveSession, then the session of the emitted authstate will be null, because it uses _currentSession which is still null if _saveSession has not been called.
Vinzent03
suggested changes
Mar 29, 2023
dshukertjr
reviewed
Mar 30, 2023
dshukertjr
reviewed
Mar 30, 2023
dshukertjr
approved these changes
Mar 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
If
_notifyAllSubscribersis called before_saveSession, then thesessionof the emittedAuthStatewill benull, because it uses_currentSessionwhich is stillnullif_saveSessionhas not been called.What is the current behavior?
With #127 the session of the emitted
AuthStateisnull.What is the new behavior?
Same as before #127 , emitted
AuthStatecontains the corresponding session.Additional context