This repository has been archived by the owner on May 13, 2023. It is now read-only.
fix: signedIn event will not fire for passwordRecovery event #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
Interesting. Just stepped out for a bit, but will take a look later. Thanks for the heads up! |
Vinzent03
approved these changes
Apr 7, 2023
|
Oh, so the tests are now passing huh? Thanks for re-running them @Vinzent03 ! |
|
@dshukertjr No, I pushed a fix to this pr. |
|
Ah, missed it! Thanks for that! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Currently,
signedInevent fires for everypasswordRecoveryevent, which is not so intuitive. This PR prevents fromsignedInevent from firing for apasswordRecoveryevent.Copied over from this js PR https://github.com/supabase/gotrue-js/pull/629/files