Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: internalize implementation #925

Merged
merged 4 commits into from
Feb 3, 2023
Merged

feat: internalize implementation #925

merged 4 commits into from
Feb 3, 2023

Conversation

hf
Copy link
Contributor

@hf hf commented Feb 1, 2023

Most of the GoTrue Go code should not be used in external imports, as it's an internal implementation. It is thus moved to an internal package which can't be imported from the outside.

From this point on you won't be able to access implementation details by importing github.com/netlify/gotrue/api for example.

@hf hf requested a review from a team as a code owner February 1, 2023 10:37
Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should probably get this in ASAP so merge conflicts don't pile up since this PR is quite wide reaching

```bash
for f in **/*.go; do sed -i '' -e 's/"github.com\/netlify\/gotrue\//"github.com\/netlify\/gotrue\/internal\//g' "$f"; done
```

```bash
for f in **/*.go; do sed -i '' -e 's/"github.com\/netlify\/gotrue\/internal\/cmd/"github.com\/netlify\/gotrue\/cmd/g' "$f"; done
```
@hf hf merged commit 1a52eb6 into master Feb 3, 2023
@hf hf deleted the hf/add-internal branch February 3, 2023 15:05
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

🎉 This PR is included in version 2.45.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants