Reject requests when worker is down #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-chavez
commented
Oct 12, 2021
| @@ -21,6 +21,25 @@ create table net.http_request_queue( | |||
|
|
|||
| create index created_idx on net.http_request_queue (created); | |||
|
|
|||
| create or replace function net._check_worker_is_up() returns trigger as $$ | |||
| begin | |||
| if not exists (select pid from pg_stat_activity where backend_type = 'pg_net worker') then | |||
There was a problem hiding this comment.
Enforced the condition with SQL.
My original plan was updating a GUC with C in the worker(as mentioned on #44 (comment)), but using the DefineCustomBoolVariable() plus SetConfigOption() didn't seem to work. So I just did it with SQL.
soedirgo
reviewed
Oct 12, 2021
| $$ language plpgsql; | ||
|
|
||
| create trigger ensure_worker_is_up | ||
| after insert on net.http_request_queue |
There was a problem hiding this comment.
Should this be before insert instead?
There was a problem hiding this comment.
Yeah, in this case we don't care for the NEW/OLD values of the row(or not even the row for that matter) so an AFTER insert should do.
soedirgo
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #45.
When the worker is down for any reason the request queue will now reject insertions.