-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automate pg_upgrade testing #695
Conversation
e8ffe54
to
36cdfb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed this earlier - gave it a quick skim and looks great. Any changes needed to bring it up to speed?
@supabase/postgres any concerns with this change?
lgtm, @soedirgo could you give this a once over? |
Looks great! 👍I guess we don't need to include Testinfra tests since this should only affect PG stuff? |
Is it possible to run these tests locally? |
Need to follow up on this and merge the more recent upgrade script changes into it. @steve-chavez running |
Yep! This would run as a parallel check to those, so no dependency between the two workflows |
Will merge after tomorrow's (Jun 13th) prod deploy, to have more ample time for testing the pg_upgrade scripts |
DRY_RUN
flag and introduces anIS_CI
flag--check
) before every upgrade, should make it easier to spot if any prerequisites are are failing, before the migration actually startsTo FLUP: