fix: return 204 when deleting tenant

lib/realtime/api.ex

@@ -102,9 +102,7 @@ defmodule Realtime.Api do
 
   @spec delete_tenant_by_external_id(String.t()) :: true | false
   def delete_tenant_by_external_id(id) do
-    Cachex.del(:tenants, id)
-    {num, _} = from(t in Tenant, where: t.external_id == ^id) |> Repo.delete_all()
-    num > 0
+    from(t in Tenant, where: t.external_id == ^id) |> Repo.delete_all()
   end
 
   @doc """

lib/realtime_web/controllers/tenant_controller.ex

@@ -107,14 +107,8 @@ defmodule RealtimeWeb.TenantController do
   end
 
   def delete(conn, %{"id" => id}) do
-    status =
-      if Api.delete_tenant_by_external_id(id) do
-        204
-      else
-        404
-      end
-
-    send_resp(conn, status, "")
+    Api.delete_tenant_by_external_id(id)
+    send_resp(conn, 204, "")
   end
 
   def swagger_definitions do

test/realtime_web/controllers/tenant_controller_test.exs

@@ -135,7 +135,7 @@ defmodule RealtimeWeb.TenantControllerTest do
     test "tenant doesn't exist", %{conn: conn, tenant: tenant} do
       with_mock JwtVerification, verify: fn _token, _secret -> {:ok, %{}} end do
         conn = delete(conn, Routes.tenant_path(conn, :delete, "wrong_external_id"))
-        assert response(conn, 404)
+        assert response(conn, 204)
       end
     end
   end