feat: return size and mime types in bucket GET (#303)

supabase · Apr 9, 2023 · 5dca04d · 5dca04d
1 parent 24cabad
commit 5dca04d
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/src/http/routes/bucket/getAllBuckets.ts b/src/http/routes/bucket/getAllBuckets.ts
@@ -12,6 +12,9 @@ const successResponseSchema = {
         id: 'avatars',
         name: 'avatars',
         owner: '4d56e902-f0a0-4662-8448-a4d9e643c142',
+        public: false,
+        file_size_limit: 1000000,
+        allowed_mime_types: ['image/png', 'image/jpeg'],
         created_at: '2021-02-17T04:43:32.770206+00:00',
         updated_at: '2021-02-17T04:43:32.770206+00:00',
       },
@@ -33,7 +36,7 @@ export default async function routes(fastify: FastifyInstance) {
     },
     async (request, response) => {
       const results = await request.storage.listBuckets(
-        'id, name, public, owner, created_at, updated_at'
+        'id, name, public, owner, created_at, updated_at, file_size_limit, allowed_mime_types'
       )
 
       request.log.info({ results }, 'results')

diff --git a/src/storage/schemas/bucket.ts b/src/storage/schemas/bucket.ts
@@ -19,6 +19,9 @@ export const bucketSchema = {
     {
       id: 'bucket2',
       name: 'bucket2',
+      public: false,
+      file_size_limit: 1000000,
+      allowed_mime_types: ['image/png', 'image/jpeg'],
       owner: '4d56e902-f0a0-4662-8448-a4d9e643c142',
       created_at: '2021-02-17T04:43:32.770206+00:00',
       updated_at: '2021-02-17T04:43:32.770206+00:00',

diff --git a/src/test/bucket.test.ts b/src/test/bucket.test.ts
@@ -48,7 +48,13 @@ describe('testing GET bucket', () => {
     })
     expect(response.statusCode).toBe(200)
     const responseJSON = JSON.parse(response.body)
-    expect(responseJSON.id).toBe(bucketId)
+    expect(responseJSON).toMatchObject({
+      id: bucketId,
+      name: bucketId,
+      public: false,
+      file_size_limit: 0,
+      allowed_mime_types: null,
+    })
   })
 
   test('checking RLS: anon user is not able to get bucket details', async () => {
@@ -98,6 +104,13 @@ describe('testing GET all buckets', () => {
     expect(response.statusCode).toBe(200)
     const responseJSON = JSON.parse(response.body)
     expect(responseJSON.length).toBe(10)
+    expect(responseJSON[0]).toMatchObject({
+      id: expect.any(String),
+      name: expect.any(String),
+      public: expect.any(Boolean),
+      file_size_limit: expect.any(Number),
+      allowed_mime_types: null,
+    })
   })
 
   test('checking RLS: anon user is not able to get all buckets', async () => {