Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mime-types and max-file-size #308

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Apr 11, 2023

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

  • Allow null for file_size_limit and allowed_mime_types
  • Add more strict validations on mime types

@coveralls
Copy link

coveralls commented Apr 11, 2023

Pull Request Test Coverage Report for Build 4665820230

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 57 of 93 (61.29%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 84.177%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http/routes/tus/lifecycle.ts 6 8 75.0%
src/storage/uploader.ts 26 32 81.25%
src/storage/storage.ts 12 40 30.0%
Files with Coverage Reduction New Missed Lines %
src/storage/storage.ts 1 80.19%
Totals Coverage Status
Change from base Build 4655784878: -0.3%
Covered Lines: 7026
Relevant Lines: 8283

💛 - Coveralls

@fenos fenos force-pushed the fix/allow-null-maxfilesize-and-mimes branch 2 times, most recently from 99ec57c to 7160b1d Compare April 11, 2023 09:07
src/storage/storage.ts Outdated Show resolved Hide resolved
@fenos fenos force-pushed the fix/allow-null-maxfilesize-and-mimes branch from 7160b1d to b957f53 Compare April 11, 2023 09:12
@fenos fenos force-pushed the fix/allow-null-maxfilesize-and-mimes branch from b957f53 to f4902d7 Compare April 11, 2023 09:53
@fenos fenos merged commit f1e104f into master Apr 11, 2023
@fenos fenos deleted the fix/allow-null-maxfilesize-and-mimes branch April 11, 2023 09:58
@github-actions
Copy link

🎉 This PR is included in version 0.37.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants